`callback` was not beying fetched by Genshi's Buffet pugin interface

[palgarvio]

Here a fix for that problem:

genshi/template/plugin.py

@@ -48 +48 @@
 
         self.default_encoding = options.get('genshi.default_encoding', 'utf-8')
         auto_reload = options.get('genshi.auto_reload', '1')
+        callback = options.get('genshi.callback', None)
         if isinstance(auto_reload, basestring):
             auto_reload = auto_reload.lower() in ('1', 'on', 'yes', 'true')
         search_path = filter(None, options.get('genshi.search_path', '').split(':'))
@@ -67 +68 @@
                                      auto_reload=auto_reload,
                                      max_cache_size=max_cache_size,
                                      default_class=self.template_class,
-                                     variable_lookup=lookup_errors)
+                                     variable_lookup=lookup_errors,
+                                     callback=callback)
 
     def load_template(self, templatename, template_string=None):
         """Find a template specified in python 'dot' notation, or load one from

[cmlenz]

This is a bit weird, I'd normally expect every config option to be represented (or at least representable) as a string in a configuration file.

Is there no other way to set this up via Pylons? Can't you access the plugin object, and through that the associated template loader, and set up the callback that way?

[palgarvio]

First of all why not include that callback option in AbstractTemplateEnginePluginsince you already have default_encoding, auto_reload, max_cache_size and search_path there, which are also options of TemplateLoader?

Seccond, next release of Pylons will accept specifying the templating engine when creating a new project which will make the necessary changes/additions and still keep it pretty simple.

The path you're specifying might be possible(I haven't tested it) but will complicate stuff a lot more.

Currently to use genshi as templating engine all one has to do is:

config.init_app(global_conf, app_conf, package='<app_name>',
                template_engine="genshi")

With the callback option we use the above and on another file:

def template_loaded(template):
    template.filters.insert(0, Translator(ugettext))

 (.....)

tmpl_options['genshi.callback'] = template_loaded

Or in just a single file:

def template_loaded(template):
    template.filters.insert(0, Translator(ugettext))

 (.....)

config.init_app(global_conf, app_conf, package='audioserv')
config.template_engines = []
config.add_template_engine('genshi', 'audioserv.templates',
                           {'genshi.callback': template_loaded})

Still want me to investigate your option?

[anonymous]

Replying to palgarvio:

First of all why not include that callback option in AbstractTemplateEnginePluginsince you already have default_encoding, auto_reload, max_cache_size and search_path there, which are also options of TemplateLoader?

As I said, those options are expected to be strings, usually, because they are often read from configuration files. I'm not sure about adding an option that cannot be easily represented as a string, in this case a function that needs context to be useful.

Still want me to investigate your option?

Yeah. If it's possible, I can't imagine it'd be that much more complex.

[palgarvio]

Ok here's the solution for Pylons, aka, monkey patching:

    config.init_app(global_conf, app_conf, package='audioserv',
                    template_engine="genshi")
    # Monkey patch Genshi's TemplateLoader so we can get i18n working
    from genshi.template.loader import TemplateLoader
    TemplateLoader.callback = template_loaded

[palgarvio]

Re-Opening as per cmlenz request.

[palgarvio]

Also consider this one an ugly approach, ie, I instantiate it myself?

    from pylons.templating import available_engines
    genshi = available_engines['genshi']()
    genshi.loader.callback = template_loaded

Pylons seems to pass only the method, which is probably called elsewhere. Look here.

[palgarvio]

The above Monkey Patch approaches do not solve the problem, sometimes the Translator filter does not get added to the template filters. Seems accepting this patch might be the only way.

[cmlenz]

More comprehensive patch

[cmlenz]

Done in [646], ported to 0.4.x in [647].